benchtool: avoid registering DNS metrics twice #188
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @edma2 for your contribution! The changes LGTM. I think we could add a quick test to |
|
@gotjosh I'm happy to add a test - but I'm unsure where to start. One idea is to call |
|
Ah, you're right. Adding this test doesn't look as simple as I originally thought. In that case, I'm happy to proceed as is - can you please add a changelog entry? Something like this within cmd/bechtool should do the trick. e.g. |
|
Sure thing, added to CHANGELOG. |
gotjosh
approved these changes
Jun 4, 2021
Co-authored-by: gotjosh <[email protected]>
|
Thanks! |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Tom Hayward <[email protected]> improve CI rules Signed-off-by: ShuzZzle <[email protected]>
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
This reverts commit 6620fde. Signed-off-by: Tom Hayward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling both query and write capabilities (
bench.query.enabled,bench.write.enabled) will result in this error on startup:Use a different metric prefix for query and write runners.